Review main Merged

19204[BUGFIX] Error in filelist for Storage context menu

Nicole Hummel CR +2 V +2 Normal +62 −17 updated 06/03/13, 20:49

Commit message

The click menu for storage roots or mount points in filelist contains
functions which are not supported (e.g. cut/copy). This patch improves the
menu and only displays options which are allowed for storages/mount points
and for the current user.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 3

Review log 14

  1. Andreas Wolf uploaded patch set 2 03/24/13, 10:25

  2. Andreas Wolf uploaded patch set 3 03/24/13, 10:25

  3. Andreas Wolf uploaded patch set 4 03/24/13, 10:25

  4. Andreas Wolf commented on patch set 4 V 0 03/24/13, 10:25

    by team member; Looks good to me, approved Just reworded the commit message (Benni, Nicole and I agreed that this is not a feature, but fixes a crash and thus a serious bug).
  5. Tom commented on patch set 3 03/24/13, 10:25

    Looks good to me, but someone else must approve
  6. Alexander Opitz commented on patch set 1 03/24/13, 10:25

    Fails; Looks good to me, but someone else must approve

    ClickMenu.php:758

    This should be $isOnline = FALSE;
  7. Alexander Opitz commented on patch set 3 03/24/13, 10:25

    Verified; Looks good to me, but someone else must approve
  8. Felix Nagel commented on patch set 3 03/24/13, 10:25

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 03/24/13, 10:25

  10. Mr. Jenkins commented on patch set 2 03/24/13, 10:25

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7919/ : FAILURE
  11. Mr. Jenkins commented on patch set 3 03/24/13, 10:25

  12. Mr. Jenkins commented on patch set 4 03/24/13, 10:25

  13. Nicole Hummel commented on patch set 3 03/24/13, 10:25

    Verified; Looks good to me, but someone else must approve

    ClickMenu.php:744

    Remove namespace as it is injected
  14. Andreas Wolf merged patch set 5 03/24/13, 10:25