Review main Merged

19207[BUG] sys_file_reference: missing exclude fields for Non-Admins

Benni Mack CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Currently, only link, but not description and alternative
is a exclude field. So the others are ALWAYS visible.
They need to be adjusted as well.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Felix Nagel +1
    • Tom +1
  • Verified V +2
    • Andreas Wolf +2
    • Felix Nagel +1
    • Tom +1

Issues 1

Files 1

Review log 7

  1. Tom commented on patch set 2 03/24/13, 09:12

    Verified; Looks good to me, but someone else must approve
  2. Benni Mack uploaded patch set 2 03/24/13, 09:12

  3. Felix Nagel commented on patch set 2 03/24/13, 09:12

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 03/24/13, 09:12

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7892/ : FAILURE
  5. Mr. Jenkins commented on patch set 2 03/24/13, 09:12

  6. Andreas Wolf commented on patch set 2 V 0 03/24/13, 09:12

    by team member; Looks good to me, approved
  7. Andreas Wolf merged patch set 3 03/24/13, 09:12