Review TYPO3_6-0 Merged

19216[BUGFIX] FAL Upgrade Wizards do not set pid

Benni Mack CR +2 V +2 Normal +151 −2 updated 01/06/19, 11:15

Commit message

The sys_file_reference records are originally set to
be placed on rootLevel, the upgrade wizard does
exactly that.

However, the concept in this case is flawed
- When creating new sys_file_reference records via IRRE,
   the sys_file_reference is stored on the page
- When copying moving e.g. a tt_content record, all its
   child elements are placed on that new page as
   well (so this works)
- rootLevel restriction is not needed in this case

The patch does the following:
- Modify the existing upgrade wizard to place the
   sys_file_references on the pages of the foreign
   tables (tt_content pid)
- the rootLevel flag for sys_file_reference is removed
- Add a new upgrade wizard is added to ensure the
integrity of the sys-file-reference pids

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5