Review TYPO3_6-0 Merged

19246[BUGFIX] Error in filelist for Storage context menu

Nicole Hummel CR +2 V +2 Normal +91 −11 updated 06/03/13, 20:49

Commit message

The click menu for storage roots or mount points in filelist contains
functions which are not supported (e.g. cut/copy). This patch improves the
menu and only displays options which are allowed for storages/mount points
and for the current user.

Review

  • Code review CR +2
    • Steffen Ritter +2
  • Verified V +2
    • Steffen Ritter +2

Issues 1

Files 3

Review log 3

  1. Steffen Ritter commented on patch set 1 04/05/13, 19:12

    I would prefer that you didn't submit this

    ClickMenu.php:710

    isFolder

    ClickMenu.php:755

    online check missing

    ClickMenu.php:787

    switch the conditions parameters for better performance

    ClickMenu.php:791

    isOnline and isFolder to front (performance)

    ClickMenu.php:795

    same

    ClickMenu.php:808

    same here

    ClickMenu.php:812

    same here

    ClickMenu.php:830

    please don't -- accidentilly deleting storages is to risky.

    ClickMenu.php:833

    check for write access to the folder?
  2. Steffen Ritter commented on patch set 1 V 0 04/05/13, 19:12

    by team member; Looks good to me, approved merging to 6.0 as it's same as in master, remarks will be tackled in follow up
  3. Steffen Ritter merged patch set 2 04/05/13, 19:12