Review main Merged

1927[BUGFIX] Variable was wrongly initialized

Stefano Kowalke CR +2 V +2 Easy +2 −1 updated 06/03/13, 20:49

Commit message

Variable $codeLines should be initialized prior to being used
in a concatenation within the loop.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Markus Klein +1
  • Verified V +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 26

Show 1 earlier messages
  1. Markus Klein commented on patch set 1 05/10/11, 12:09

    I would prefer that you didn't submit this Please update your commit message to be more specific about what problem is solved.
  1. Stefan Neufeind commented on patch set 2 05/10/11, 12:09

    Looks good to me, but someone else must approve
  2. Stefan Neufeind commented on patch set 2 05/10/11, 12:09

    I would prefer that you didn't submit this I agree to Steffen that initialisation should be done fore the loop. Didn't notice that on first look since the loop is quite "large".
  3. Oliver Klee commented on patch set 2 05/10/11, 12:09

    Looks good to me, but someone else must approve
  4. Stefan Neufeind commented on patch set 3 05/10/11, 12:09

    Looks good to me, but someone else must approve Patch looks okay now. Only some CS-fixes and init of $codeLines before loop now. Jenkins seem to have tripped an internal error, imho not related to this patch: http://ci.typo3.org/job/typo3-v4-core-gerrit/443/console
  5. Xavier Perseguers uploaded patch set 3 05/10/11, 12:09

  6. Steffen Gebert commented on patch set 2 05/10/11, 12:09

    I would prefer that you didn't submit this This code runs inside a foreach loop. So initialization has to take place before the loop.
  7. Stefano Kowalke uploaded patch set 2 05/10/11, 12:09

  8. Stefano Kowalke uploaded patch set 4 05/10/11, 12:09

  9. Xavier Perseguers commented on patch set 5 05/10/11, 12:09

    Please wait before submitting new patches. The Mr Jenkins problem is currently tackled with...
  10. Stefan Neufeind commented on patch set 6 05/10/11, 12:09

    Looks good to me, but someone else must approve
  11. Markus Klein commented on patch set 6 05/10/11, 12:09

    Looks good to me, but someone else must approve
  12. Xavier Perseguers commented on patch set 6 05/10/11, 12:09

    Looks good to me, but someone else must approve
  13. Xavier Perseguers uploaded patch set 6 05/10/11, 12:09

  14. Stefano Kowalke uploaded patch set 5 05/10/11, 12:09

  15. Mr. Jenkins commented on patch set 1 05/10/11, 12:09

  16. Mr. Jenkins commented on patch set 2 05/10/11, 12:09

  17. Mr. Jenkins commented on patch set 3 05/10/11, 12:09

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/443/ : FAILURE
  18. Mr. Jenkins commented on patch set 4 05/10/11, 12:09

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/444/ : FAILURE
  19. Mr. Jenkins commented on patch set 4 05/10/11, 12:09

  20. Mr. Jenkins commented on patch set 4 05/10/11, 12:09

  21. Mr. Jenkins commented on patch set 5 05/10/11, 12:09

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/448/ : FAILURE
  22. Mr. Jenkins commented on patch set 6 05/10/11, 12:09

    No score; No score Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/450/ : SUCCESS
  23. Mr. Jenkins commented on patch set 6 05/10/11, 12:09

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/449/ : FAILURE
  24. Xavier Perseguers commented on patch set 6 V 0 05/10/11, 12:09

    by team member; Looks good to me, approved
  25. Xavier Perseguers merged patch set 6 05/10/11, 12:09