1927[BUGFIX] Variable was wrongly initialized
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Markus Klein +1
-
Verified V +2
- Xavier Perseguers +2
Issues 1
Files 1
Review log 26
Show 1 earlier messages
-
Markus Klein commented on patch set 1 05/10/11, 12:09
I would prefer that you didn't submit this Please update your commit message to be more specific about what problem is solved.
-
Stefan Neufeind commented on patch set 2 05/10/11, 12:09
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 05/10/11, 12:09
I would prefer that you didn't submit this I agree to Steffen that initialisation should be done fore the loop. Didn't notice that on first look since the loop is quite "large". -
Oliver Klee commented on patch set 2 05/10/11, 12:09
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 05/10/11, 12:09
Looks good to me, but someone else must approve Patch looks okay now. Only some CS-fixes and init of $codeLines before loop now. Jenkins seem to have tripped an internal error, imho not related to this patch: http://ci.typo3.org/job/typo3-v4-core-gerrit/443/console -
Xavier Perseguers uploaded patch set 3 05/10/11, 12:09
-
Steffen Gebert commented on patch set 2 05/10/11, 12:09
I would prefer that you didn't submit this This code runs inside a foreach loop. So initialization has to take place before the loop. -
Stefano Kowalke uploaded patch set 2 05/10/11, 12:09
-
Stefano Kowalke uploaded patch set 4 05/10/11, 12:09
-
Xavier Perseguers commented on patch set 5 05/10/11, 12:09
Please wait before submitting new patches. The Mr Jenkins problem is currently tackled with... -
Stefan Neufeind commented on patch set 6 05/10/11, 12:09
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 6 05/10/11, 12:09
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 6 05/10/11, 12:09
Looks good to me, but someone else must approve -
Xavier Perseguers uploaded patch set 6 05/10/11, 12:09
-
Stefano Kowalke uploaded patch set 5 05/10/11, 12:09
-
Mr. Jenkins commented on patch set 1 05/10/11, 12:09
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/431/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/10/11, 12:09
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/433/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/10/11, 12:09
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/443/ : FAILURE -
Mr. Jenkins commented on patch set 4 05/10/11, 12:09
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/444/ : FAILURE -
Mr. Jenkins commented on patch set 4 05/10/11, 12:09
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/445/ : FAILURE -
Mr. Jenkins commented on patch set 4 05/10/11, 12:09
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/447/ : FAILURE -
Mr. Jenkins commented on patch set 5 05/10/11, 12:09
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/448/ : FAILURE -
Mr. Jenkins commented on patch set 6 05/10/11, 12:09
No score; No score Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/450/ : SUCCESS -
Mr. Jenkins commented on patch set 6 05/10/11, 12:09
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/449/ : FAILURE -
Xavier Perseguers commented on patch set 6 V 0 05/10/11, 12:09
by team member; Looks good to me, approved -
Xavier Perseguers merged patch set 6 05/10/11, 12:09