Review main Merged Breaking

19438[!!!][BUGFIX] Scope of ProcessedFile cannot be modified

Oliver Hader CR +2 V +2 Normal +52 −16 updated 06/03/13, 20:49

Commit message

A ProcessedFile is used to generate a preview or crop-scaled
version of a File. Actually a Task implementing the
TaskInterface defines the basics and an accordant Helper
object takes care of the modifications to that file.
There are pre-process and post-process signals that seem to
be useless in modifying the scope of a particular task, however.

Imagine a file shall be pre-processed (e.g. color profile
transformation) and that result shall be used for resizing.
The current task implementation is using the original file
directly, however the task actually shall define which is the
source (the original file) the modifications shall be based on.

This change modifies the TaskInterface with a getSourceFile()
method to overcome this limitation.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Oliver Hader +2
    • Stefan Neufeind +1
    • Philipp Gampe +1
  • Verified V +2
    • Oliver Hader +2
    • Steffen Ritter +1
    • Philipp Gampe +1

Files 5

Review log 8

  1. Stefan Neufeind commented on patch set 1 04/01/13, 20:44

    Looks good to me, but someone else must approve
  2. Steffen Ritter commented on patch set 1 04/01/13, 20:44

    Looks good to me, but someone else must approve
  3. Steffen Ritter voted on patch set 1 V 0 04/01/13, 20:44

  4. Steffen Ritter commented on patch set 1 04/01/13, 20:44

    Looks good to me, approved
  5. Philipp Gampe commented on patch set 1 04/01/13, 20:44

    Verified; Looks good to me, but someone else must approve Tested with Oli's fal_profile extension: https://github.com/ohader/fal_profile
  6. Mr. Jenkins commented on patch set 1 04/01/13, 20:44

  7. Oliver Hader commented on patch set 1 V 0 04/01/13, 20:44

    by team member; Looks good to me, approved
  8. Oliver Hader merged patch set 2 04/01/13, 20:44