19438[!!!][BUGFIX] Scope of ProcessedFile cannot be modified
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Oliver Hader +2
- Stefan Neufeind +1
- Philipp Gampe +1
-
Verified V +2
- Oliver Hader +2
- Steffen Ritter +1
- Philipp Gampe +1
Files 5
- typo3/sysext/core/Classes/Resource/Processing/AbstractGraphicalTask.php+2 −2
- typo3/sysext/core/Classes/Resource/Processing/AbstractTask.php+28 −1
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+9 −8
- typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php+6 −5
- typo3/sysext/core/Classes/Resource/Processing/TaskInterface.php+7 −0
Review log 8
-
Stefan Neufeind commented on patch set 1 04/01/13, 20:44
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 1 04/01/13, 20:44
Looks good to me, but someone else must approve -
Steffen Ritter voted on patch set 1 V 0 04/01/13, 20:44
-
Steffen Ritter commented on patch set 1 04/01/13, 20:44
Looks good to me, approved -
Philipp Gampe commented on patch set 1 04/01/13, 20:44
Verified; Looks good to me, but someone else must approve Tested with Oli's fal_profile extension: https://github.com/ohader/fal_profile -
Mr. Jenkins commented on patch set 1 04/01/13, 20:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7998/ : SUCCESS -
Oliver Hader commented on patch set 1 V 0 04/01/13, 20:44
by team member; Looks good to me, approved -
Oliver Hader merged patch set 2 04/01/13, 20:44