Review main Merged

19460[FEATURE] Add wincache and zend to opcode cache check

Wouter Wolters CR +2 V +2 Easy +11 −7 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 16

  1. Stefan Neufeind commented on patch set 1 03/31/13, 15:35

    Looks good to me, but someone else must approve no-brainer
  2. Christian Kuhn commented on patch set 1 03/31/13, 15:35

    I would prefer that you didn't submit this

    Check.php:674

    I don't think this is correct, imho the module is called opcache?
  3. Stefan Neufeind commented on patch set 2 03/31/13, 15:35

    Looks good to me, but someone else must approve not really easy to fully "test". But we discussed the extension-names on Skype. no-brainer?
  4. Christian Kuhn uploaded patch set 2 03/31/13, 15:35

  5. Christian Kuhn commented on patch set 2 03/31/13, 15:35

    Verified; Looks good to me, but someone else must approve
  6. Stefan Neufeind commented on patch set 3 03/31/13, 15:35

    Verified; Looks good to me, but someone else must approve nothing to really verify
  7. Christian Kuhn commented on patch set 3 03/31/13, 15:35

    Verified; Looks good to me, but someone else must approve
  8. Christian Kuhn uploaded patch set 3 03/31/13, 15:35

  9. Anja Leichsenring commented on patch set 3 03/31/13, 15:35

    Verified; Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 1 03/31/13, 15:35

  11. Mr. Jenkins commented on patch set 2 03/31/13, 15:35

  12. Mr. Jenkins commented on patch set 3 03/31/13, 15:35

  13. Wouter Wolters commented on patch set 2 03/31/13, 15:35

    Verified; Looks good to me, but someone else must approve
  14. Wouter Wolters commented on patch set 3 03/31/13, 15:35

    Verified; Looks good to me, but someone else must approve
  15. Christian Kuhn commented on patch set 3 V 0 03/31/13, 15:35

    by team member; Looks good to me, approved
  16. Christian Kuhn merged patch set 4 03/31/13, 15:35