19460[FEATURE] Add wincache and zend to opcode cache check
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Anja Leichsenring +1
Issues 1
Files 1
Review log 16
-
Stefan Neufeind commented on patch set 1 03/31/13, 15:35
Looks good to me, but someone else must approve no-brainer -
Christian Kuhn commented on patch set 1 03/31/13, 15:35
I would prefer that you didn't submit thisCheck.php:674I don't think this is correct, imho the module is called opcache? -
Stefan Neufeind commented on patch set 2 03/31/13, 15:35
Looks good to me, but someone else must approve not really easy to fully "test". But we discussed the extension-names on Skype. no-brainer? -
Christian Kuhn uploaded patch set 2 03/31/13, 15:35
-
Christian Kuhn commented on patch set 2 03/31/13, 15:35
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 03/31/13, 15:35
Verified; Looks good to me, but someone else must approve nothing to really verify -
Christian Kuhn commented on patch set 3 03/31/13, 15:35
Verified; Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 3 03/31/13, 15:35
-
Anja Leichsenring commented on patch set 3 03/31/13, 15:35
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/31/13, 15:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8047/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/31/13, 15:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8049/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/31/13, 15:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8050/ : SUCCESS -
Wouter Wolters commented on patch set 2 03/31/13, 15:35
Verified; Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 3 03/31/13, 15:35
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 3 V 0 03/31/13, 15:35
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 4 03/31/13, 15:35