Review main Merged

19473[BUGFIX] MySQLi: FALSE not NULL from sql_fetch()/fetch_row()

Stefan Neufeind CR +2 V +2 Easy +12 −2 updated 06/03/13, 20:49

Commit message

MySQL previously returned FALSE if there were no more rows.
MySQLi returns NULL. So we'll need to turn that into FALSE
again not to break things.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 1

Review log 6

  1. Christian Kuhn uploaded patch set 2 03/31/13, 20:27

  2. Christian Kuhn commented on patch set 2 03/31/13, 20:27

    Verified; Looks good to me, but someone else must approve nasty!
  3. Mr. Jenkins commented on patch set 1 03/31/13, 20:27

  4. Mr. Jenkins commented on patch set 2 03/31/13, 20:27

  5. Christian Kuhn commented on patch set 2 V 0 03/31/13, 20:27

    by team member; Looks good to me, approved
  6. Christian Kuhn merged patch set 3 03/31/13, 20:27