Review main Merged 19481[BUGFIX] TypoScriptParserTest uses superfluous mock object Oliver Hader CR +2 V +2 Easy +4 −6 updated 06/03/13, 20:49 Open in Gerrit Commit message Show more TypoScriptParserTest uses superfluous mock object just to call protected methods but without using mock behaviour. Change-Id: Iaf8ed0150e63b5da4185dccbcf3dbd5eaa0cf94f Fixes: #46833 Releases: 6.1 Reviewed-on: https://review.typo3.org/19481 Reviewed-by: Oliver Hader Tested-by: Oliver Hader Review Code review CR +2 Oliver Hader +2 Verified V +2 Oliver Hader +2 Files 1 typo3/sysext/core/Tests/Unit/TypoScript/Parser/TypoScriptParserTest.php+4 −6 Review log 3 Mr. Jenkins commented on patch set 1 04/01/13, 10:34 Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8070/ : SUCCESS Oliver Hader commented on patch set 1 V 0 04/01/13, 10:34 by team member; Looks good to me, approved Oliver Hader merged patch set 2 04/01/13, 10:34