Review main Abandoned

19539Revert "[BUGFIX] Impossible to save the TCA configuration"

Helmut Hummel CR 0 V 0 Easy +1 −4 updated 06/03/13, 20:49

Commit message

This reverts commit 1adb3aa1748b0e4d93c4a90e85147d3d33f0d800

This made extTables.php mandatory, which is not to be expected and not wanted. especially not for a released version

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 4

  1. Christian Kuhn commented on patch set 1 04/06/13, 19:20

    I would prefer that you didn't submit this
  2. Christian Kuhn commented on patch set 1 04/06/13, 19:20

    lets fix the warning, then. in fact, setting the constant to some sane value is imho better than ending up with an empty string for it. Usages should check with file_exists then.
  3. Mr. Jenkins commented on patch set 1 04/06/13, 19:20

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8113/ : FAILURE
  4. Christian Kuhn commented on patch set 1 04/06/13, 19:20

    Abandoned abondoned in 6.0, warning will be fixed by philipp in 6.0 in frontend.