Review main Merged

19616[BUGFIX] EM: Colorpicker in extension configuration is broken

Wouter Wolters CR +2 V +2 Easy +9 −9 updated 06/03/13, 20:49

Commit message

The colorpicker in extension configruation is broken. This is
because of missing images.

Also this fixes an issue with duplicate ID tags on a page. Which
causes some problem when CSS is defined on the same name.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +1

Files 4

Review log 6

  1. Mr. Jenkins commented on patch set 1 04/05/13, 20:16

  2. Christian Kuhn commented on patch set 2 V 0 04/05/13, 20:16

    by team member; Looks good to me, approved
  3. Mr. Jenkins commented on patch set 2 04/05/13, 20:16

  4. Wouter Wolters uploaded patch set 2 04/05/13, 20:16

  5. Nicole Hummel commented on patch set 2 04/05/13, 20:16

    Verified; Looks good to me, but someone else must approve
  6. Christian Kuhn merged patch set 3 04/05/13, 20:16