Review main Merged

19636[BUGFIX] Illegal string offset in EditDocumentController

Philipp Gampe CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

If a content element is opened from the opendocs module, a warning is
shown because overrideVals is used without checking if it is an array.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 1

Review log 10

  1. Sascha Egerer commented on patch set 1 04/06/13, 22:02

    Looks good to me, but someone else must approve
  2. Alexander Opitz commented on patch set 1 04/06/13, 22:02

    Looks good to me, but someone else must approve
  3. Christian Kuhn commented on patch set 1 04/06/13, 22:02

    Verified; Looks good to me, but someone else must approve
  4. Christian Kuhn uploaded patch set 2 04/06/13, 22:02

  5. Christian Kuhn commented on patch set 2 V 0 04/06/13, 22:02

    by team member; Looks good to me, approved
  6. Christian Kuhn commented on patch set 2 04/06/13, 22:02

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 04/06/13, 22:02

  8. Wouter Wolters commented on patch set 1 04/06/13, 22:02

    Looks good to me, but someone else must approve
  9. Magdalena Leichsenring commented on patch set 1 04/06/13, 22:02

    Looks good to me, but someone else must approve
  10. Christian Kuhn merged patch set 3 04/06/13, 22:02