19714[FEATURE] Add Drag&Drop Upload to file-list
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Steffen Ritter +1
- Frans Saris +1
-
Verified V +2
- Markus Klein +2
- Steffen Ritter +1
- Frans Saris +1
Issues 1
Files 5
- typo3/sysext/backend/Resources/Public/JavaScript/DragUploader.js3new+250 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+10 −1
- typo3/sysext/filelist/Resources/Private/Templates/file_list.html+1 −1
- typo3/sysext/lang/locallang_core.xlf6+30 −0
- typo3/sysext/t3skin/stylesheets/visual/module_file_list.css+48 −1
Review log 34
Show 9 earlier messages
-
Xavier Perseguers commented on patch set 1 05/27/13, 17:19
Remarks: - only 1 file is uploaded - drop zone should be somehow suggested *before* drag-dropping files to make people aware of the drag-and-drop feature -
Steffen Ritter uploaded patch set 2 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 3 V 0 05/27/13, 17:19
Tested it works fine with regular uploads, correctly returns with an error-message if filesize is exceeded etc. Uploading of multiple files in one drag also works. -
Steffen Ritter uploaded patch set 3 05/27/13, 17:19
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8286/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8656/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8666/ : SUCCESS -
Frans Saris uploaded patch set 4 07/05/13, 07:55
-
Mr. Jenkins commented on patch set 4 07/05/13, 07:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9372/ : SUCCESS
-
Frans Saris uploaded patch set 5 07/05/13, 12:11
-
Mr. Jenkins commented on patch set 5 07/05/13, 12:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9385/ : SUCCESS -
Frans Saris commented on patch set 5 07/05/13, 12:13
patch set 5 is the result of the workshop at T3DD. Still not ready yet but filesize check is in and the basics for the file patern check. Also made a start for a "file queue" to make the progress visuable -
Stefan Neufeind commented on patch set 5 07/05/13, 13:40
@Franz: Last time I tried it, it was already great :-) Maybe some first version that could be pushed (if one part is complete) and filing follow-up issues? Might imho lower the barrier for "the whole thing" if the basic concept is clear / won't change. -
Markus Klein commented on patch set 5 07/05/13, 14:07
@Stefan: We still need some basic changes here, otherwise follow-ups are not really useful. -
Steffen Ritter commented on patch set 5 07/05/13, 14:36
Who should do them? Are you taking care? Or Frans or me? -
Frans Saris uploaded patch set 6 07/05/13, 16:31
-
Mr. Jenkins commented on patch set 6 07/05/13, 16:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9415/ : SUCCESS -
Markus Klein commented on patch set 6 V +2 07/05/13, 16:57
DragUploader.js:77maybe utilize the 2nd parameter of localizeDragUploader.js:97fileextension is superfluous herelocallang_core.xlf:443File {0} exceeds maximum filesize of {1} bytes!locallang_core.xlf:449Upload of file {0} failed!locallang_core.xlf:452File uploadlocallang_core.xlf:455Uploading file {0} out of {1} files.locallang_core.xlf:458Upload complete! Filelist reloading...locallang_core.xlf:461Shall existing files be overridden? -
Steffen Ritter uploaded patch set 7 07/05/13, 20:35
-
Steffen Ritter voted on patch set 7 V +1 CR +1 07/05/13, 20:36
-
Mr. Jenkins commented on patch set 7 07/05/13, 20:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9427/ : SUCCESS -
Markus Klein commented on patch set 7 CR -1 07/06/13, 08:07
Will push a version with my comments fixed.DragUploader.js:180I'm not sure if the UX team appreciates this. Clicking a button twice? -
Steffen Ritter commented on patch set 7 07/06/13, 08:16
as there will be styling/ux follow ups to the D&D uploader anyhow we decided to go for that so the UX team get's an easy feeling about what we are talking about. -
Markus Klein uploaded patch set 8 07/06/13, 08:36
-
Mr. Jenkins commented on patch set 8 07/06/13, 08:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9440/ : SUCCESS -
Markus Klein voted on patch set 8 V +1 CR +1 07/06/13, 08:38
-
Philipp Gampe commented on patch set 8 V +2 07/06/13, 11:41
works, UI is something to tune ;) -
Philipp Gampe commented on patch set 8 CR +1 07/06/13, 11:44
did not fully check the JS part -
Frans Saris uploaded patch set 9 07/06/13, 13:20
-
Mr. Jenkins commented on patch set 9 07/06/13, 13:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9456/ : SUCCESS -
Steffen Ritter voted on patch set 9 V +1 CR +1 07/06/13, 13:22
-
Frans Saris commented on patch set 9 V +1 CR +1 07/06/13, 13:23
The drag/drop event is bind to the body again so you get the "drop here" notice also when the filelist doesn't fill the whole page. The green border is still on #typo3-inner-docbody -
Markus Klein commented on patch set 9 V +2 CR +2 07/06/13, 13:53
Thanks! Great work. Looking forward to the UX Team styling suggestions. -
Markus Klein merged patch set 10 07/06/13, 13:53