Review main Merged

19714[FEATURE] Add Drag&Drop Upload to file-list

Steffen Ritter CR +2 V +2 Hard +339 −3 updated 07/06/13, 13:53

Commit message

In TYPO3 6.1 the Flash-Uploader has been removed and the
upload functionality has been reduced to the basic HTML5
multi-upload field.

In the times of HTML5, CSS3 and modern browser our users
expect a way more advanced experience.

This patch adds the possibility to just drag files into the file
list. The dragged files are asynchronously uploaded to the
currently open folder and an reload of the frame is done.

There are still some minor issues and ideas for a even better
user experience, which have to be discussed if they should
be included in the original patch.

Review

  • Code review CR +2
    • Markus Klein +2
    • Steffen Ritter +1
    • Frans Saris +1
  • Verified V +2
    • Markus Klein +2
    • Steffen Ritter +1
    • Frans Saris +1

Issues 1

Files 5

Review log 34

Show 9 earlier messages
  1. Xavier Perseguers commented on patch set 1 05/27/13, 17:19

    Remarks: - only 1 file is uploaded - drop zone should be somehow suggested *before* drag-dropping files to make people aware of the drag-and-drop feature
  2. Steffen Ritter uploaded patch set 2 05/27/13, 17:19

  3. Stefan Neufeind commented on patch set 3 V 0 05/27/13, 17:19

    Tested it works fine with regular uploads, correctly returns with an error-message if filesize is exceeded etc. Uploading of multiple files in one drag also works.
  4. Steffen Ritter uploaded patch set 3 05/27/13, 17:19

  5. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  6. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  7. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  8. Frans Saris uploaded patch set 4 07/05/13, 07:55

  9. Mr. Jenkins commented on patch set 4 07/05/13, 07:56

  1. Frans Saris uploaded patch set 5 07/05/13, 12:11

  2. Mr. Jenkins commented on patch set 5 07/05/13, 12:12

  3. Frans Saris commented on patch set 5 07/05/13, 12:13

    patch set 5 is the result of the workshop at T3DD. Still not ready yet but filesize check is in and the basics for the file patern check. Also made a start for a "file queue" to make the progress visuable
  4. Stefan Neufeind commented on patch set 5 07/05/13, 13:40

    @Franz: Last time I tried it, it was already great :-) Maybe some first version that could be pushed (if one part is complete) and filing follow-up issues? Might imho lower the barrier for "the whole thing" if the basic concept is clear / won't change.
  5. Markus Klein commented on patch set 5 07/05/13, 14:07

    @Stefan: We still need some basic changes here, otherwise follow-ups are not really useful.
  6. Steffen Ritter commented on patch set 5 07/05/13, 14:36

    Who should do them? Are you taking care? Or Frans or me?
  7. Frans Saris uploaded patch set 6 07/05/13, 16:31

  8. Mr. Jenkins commented on patch set 6 07/05/13, 16:32

  9. Markus Klein commented on patch set 6 V +2 07/05/13, 16:57

    DragUploader.js:77

    maybe utilize the 2nd parameter of localize

    DragUploader.js:97

    fileextension is superfluous here

    locallang_core.xlf:443

    File {0} exceeds maximum filesize of {1} bytes!

    locallang_core.xlf:449

    Upload of file {0} failed!

    locallang_core.xlf:452

    File upload

    locallang_core.xlf:455

    Uploading file {0} out of {1} files.

    locallang_core.xlf:458

    Upload complete! Filelist reloading...

    locallang_core.xlf:461

    Shall existing files be overridden?
  10. Steffen Ritter uploaded patch set 7 07/05/13, 20:35

  11. Steffen Ritter voted on patch set 7 V +1 CR +1 07/05/13, 20:36

  12. Mr. Jenkins commented on patch set 7 07/05/13, 20:36

  13. Markus Klein commented on patch set 7 CR -1 07/06/13, 08:07

    Will push a version with my comments fixed.

    DragUploader.js:180

    I'm not sure if the UX team appreciates this. Clicking a button twice?
  14. Steffen Ritter commented on patch set 7 07/06/13, 08:16

    as there will be styling/ux follow ups to the D&D uploader anyhow we decided to go for that so the UX team get's an easy feeling about what we are talking about.
  15. Markus Klein uploaded patch set 8 07/06/13, 08:36

  16. Mr. Jenkins commented on patch set 8 07/06/13, 08:37

  17. Markus Klein voted on patch set 8 V +1 CR +1 07/06/13, 08:38

  18. Philipp Gampe commented on patch set 8 V +2 07/06/13, 11:41

    works, UI is something to tune ;)
  19. Philipp Gampe commented on patch set 8 CR +1 07/06/13, 11:44

    did not fully check the JS part
  20. Frans Saris uploaded patch set 9 07/06/13, 13:20

  21. Mr. Jenkins commented on patch set 9 07/06/13, 13:21

  22. Steffen Ritter voted on patch set 9 V +1 CR +1 07/06/13, 13:22

  23. Frans Saris commented on patch set 9 V +1 CR +1 07/06/13, 13:23

    The drag/drop event is bind to the body again so you get the "drop here" notice also when the filelist doesn't fill the whole page. The green border is still on #typo3-inner-docbody
  24. Markus Klein commented on patch set 9 V +2 CR +2 07/06/13, 13:53

    Thanks! Great work. Looking forward to the UX Team styling suggestions.
  25. Markus Klein merged patch set 10 07/06/13, 13:53