Review main Merged

19810[BUGFIX] ProcessedFile/Thumbnail is always regenerated

Oliver Hader CR +2 V +2 Easy +6 −1 updated 06/03/13, 20:49

Commit message

A ProcessedFile/Thumbnail is always regenerated even if there
are not modifications to the original file.

The reasons for this spread all over the ProcessedFile handling
and boils down to a new ProcessedFile is being persisted in the
file-system by using a regular ResourceStorage::addFile() call
that results in a plain File object. The indexer then tries to
load this file and will create a new UID for the thumbnail in
sys_file. This uid value is then used to update(!) the
sys_file_processedfile entry - which fails since the uid
was taken from sys_file.

The bug was introduced in
I53e4eb42def291ba88ce18209a348b1e2f592185 were the
processedFile is updated with information of a File object and
the wrong uid is transfered as property.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 04/14/13, 10:37

  2. Nicole Hummel commented on patch set 1 04/14/13, 10:37

    Looks good to me, but someone else must approve Will test soon. What about unit tests?
    are not = were no
  3. Mr. Jenkins commented on patch set 2 04/14/13, 10:37

  4. Nicole Hummel uploaded patch set 2 04/14/13, 10:37

  5. Oliver Hader commented on patch set 2 V 0 04/14/13, 10:37

    by team member; Looks good to me, approved
  6. Oliver Hader merged patch set 3 04/14/13, 10:37