20024[BUGFIX] Make DBgetDelete() update tstamp on delete by update
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
- Dmitry Dulepov +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
- Dmitry Dulepov +1
Files 1
Review log 13
-
Stefan Neufeind commented on patch set 1 05/27/13, 17:19
Can be tested with a table like tt_address. For example direct_mail_subscription, upon "unsubscribing" a person, will perform a delete. That record will be marked as deleted=1 then, but without this patch the tstamp would remain unchanged. -
Stefan Neufeind commented on patch set 1 05/27/13, 17:19
It's a change in behaviour after all, small but a change. If in general this finds your approval, please make up your mind to which releases this one might go to. Imho master and "maybe" 6.1 (up to Benni). -
Jigal van Hemert commented on patch set 1 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve DataHandler also updates the tstamp, so no reason why not. -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8418/ : SUCCESS -
Wouter Wolters uploaded patch set 2 05/28/13, 20:26
-
Mr. Jenkins commented on patch set 2 05/28/13, 20:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8932/ : SUCCESS -
Dmitry Dulepov commented on patch set 2 05/31/13, 07:50
Verified; Looks good to me, but someone else must approve Since this is a bug, it should be ok to go to previous releases too. -
Wouter Wolters voted on patch set 2 V +1 CR +1 06/04/13, 17:42
-
Jigal van Hemert commented on patch set 2 07/07/13, 12:18
@Benni : can this go to 6.1? -
Benni Mack commented on patch set 2 07/13/13, 18:32
yes. go for it. -
Markus Klein voted on patch set 2 V +2 CR +2 07/13/13, 18:34
-
Markus Klein merged patch set 3 07/13/13, 18:34
-
Markus Klein commented on patch set 3 07/13/13, 18:34
Cherry Picked This patchset was cherry picked to change: I61b9ce7d8608b73cfb974e79d2f9f59e6dc3547a