Review main Abandoned

20114[BUGFIX] Resolve broken call-by-reference

geetakshi CR 0 V 0 Easy +1 −1 updated 06/13/13, 16:58

Commit message

Adds '&' in array parameter of dispatch call in LoginController
to resolve broken call-by-reference

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8455/ : FAILURE
  2. Markus Klein commented on patch set 2 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Please use your real name for TYPO3 CMS contributions. Thank you! ~Markus
  3. Markus Klein commented on patch set 2 05/27/13, 17:19

    No score
  4. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  5. geetakshi uploaded patch set 2 05/27/13, 17:19

  6. Markus Klein abandoned the change 06/13/13, 16:58

    "Call-time pass-by-reference" triggers a PHP warning. See http://www.php.net/manual/en/language.references.pass.php