Review main Merged

20149[BUGFIX] header element is rendered in lib.stdheader in all HTML5 cases

Patrick Broens CR +2 V +2 Easy +8 −0 updated 08/29/13, 18:44

Commit message

According to the HTML5 specs the header element should be used for
grouping elements. Currently the header element is used if there is any
content in lib.stdheader, for instance a single hx.

This patch fixes this by wrapping lib.stdheader with the header element
only when the date is added to the header. Otherwise it will use the
default div wrapping.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Kai Ole Hartwig +1
    • Ernesto Baschny +1
  • Verified V +2
    • Wouter Wolters +2
    • Kai Ole Hartwig +1
    • Ernesto Baschny +1

Files 2

Review log 11

  1. Patrick Broens commented on patch set 1 05/27/13, 17:19

    According to the spec the header represents: a group of introductory or navigational aids. A header element typically contains the section’s heading (an h1–h6 element or an hgroup element), but can also contain other content, such as a table of contents, a search form, or any relevant logos. The date can be seen as part of the header, because it is part of the introductory aid.
  2. Dmitry Dulepov commented on patch set 1 05/27/13, 17:19

    > Wrapping lib.stdheader with the header element should only occur when the date is added to the header. Why?
  3. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  4. Ernesto Baschny commented on patch set 1 CR -1 08/28/13, 09:32

    We need to add 'compat_version' entries in css_styled_content's ext_localconf.php when changing the rendering of the frontend so that the upgrader is aware of it in the Upgrade Wizard step. This has as it seem negleted in the last couple of releases, which is why this wizard step is currently showing nothing changed - which is not true. So we should start at least with this issue and then go over other changes from the past.
  5. Ernesto Baschny uploaded patch set 2 08/28/13, 09:55

  6. Ernesto Baschny voted on patch set 2 V +1 CR +1 08/28/13, 09:56

  7. Mr. Jenkins commented on patch set 2 08/28/13, 09:56

  8. Ernesto Baschny commented on patch set 2 08/28/13, 09:57

    I've added the Upgrade Wizard message for this change. Will add an issue to add other important changes in this array as well. Since so much has changed since 4.5, probably some more generic "blobs of text" could summarize these changes better.
  9. Kai Ole Hartwig voted on patch set 2 V +1 CR +1 08/29/13, 16:00

  10. Wouter Wolters voted on patch set 2 V +2 CR +2 08/29/13, 18:44

  11. Wouter Wolters merged patch set 3 08/29/13, 18:44