Review main Merged

20155[BUGFIX] Wrong top/bottom margin rendering in CSC

Patrick Broens CR +2 V +2 Easy +2 −2 updated 07/02/13, 09:45

Commit message

When a top or bottom margin has been chosen together with section_frame
"no frame" -> 66, no entry is made in the temporary stylesheet.

This patch solves this issue by changing the stdWrap variable to
classStdWrap for the method renderSpace().

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1

Files 1

Review log 8

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  2. Marc Bastian Heinrichs commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  4. Wouter Wolters uploaded patch set 2 06/29/13, 19:43

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 06/29/13, 19:43

  6. Mr. Jenkins commented on patch set 2 06/29/13, 19:44

  7. Benni Mack voted on patch set 2 V +2 CR +2 07/02/13, 09:45

  8. Benni Mack merged patch set 3 07/02/13, 09:45