Review TYPO3_6-0 Abandoned

20204[BUGFIX]Edit the cImage() function to render closing image tags

ananth CR 0 V 0 Easy +6 −6 updated 06/03/13, 20:49

Commit message

The file typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php is to be edited to render a closing image tag.
The rendering of the closing tag is requested to avoid error in parsing the html via DOM. All <img> tags are now immediately followed by </img>
Resolves: #47097

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 3

  1. Markus Klein commented on patch set 1 04/29/13, 14:20

    I would prefer that you didn't submit this Hi Ananth! Thanks for your contribution. Unfortunately your patch has some flaws: - The commit message format does not follow our guidelines - A new patch has always to be pushed for the master branch, backports will be done, once the patch is accepted. Unfortunately I don't agree with your change here. It is valid HTML to have <img />.
  2. Steffen Gebert (Test) commented on patch set 1 04/29/13, 14:20

    I would prefer that you didn't submit this Hi ananth, I agree with Markus that I'm in favor of not merging this. What xml parser ate you using that is not capable of empty, closing tags? Esp. if you set the HTML tendering mode to XHTML, the output is a subset of XML. If you need to have empty closing tags replaced by q dedicated closing tag for a special use case, you could ask on http://forum.typo3.org to figure out a solution for you. I'm confident that it's possible, however I would not change TYPO3's default behavior. Thanks for your understanding. Yours Steffen
  3. ananth commented on patch set 1 04/29/13, 14:20

    Abandoned wont work.. patch abandoned