20280[BUGFIX] Show history in Module Info is not working
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 6
-
Jigal van Hemert commented on patch set 1 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Patch helps if the module is called inside the Info module. If it's called from the Log module the link should be like it currently is. We have to find a solution to detect in which context it's used. The controller has a property $isInPageContext, but this is protected :-S -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8524/ : SUCCESS -
Benni Mack commented on patch set 2 05/27/13, 17:19
I would prefer that you didn't submit this Hey Wouter, I think this should be done more dynamically with the PathUtility and the automatic calculation. -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8637/ : SUCCESS -
Wouter Wolters uploaded patch set 2 05/27/13, 17:19
-
Wouter Wolters abandoned the change 06/17/13, 16:47
Better solution here https://review.typo3.org/#/c/21480/