20439[BUGFIX] Remove 1000 pixelx limitation for preview image
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Alexander Opitz +1
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Alexander Opitz +1
- Christian Kuhn +1
Issues 1
Files 1
Review log 22
-
Markus Klein commented on patch set 2 05/08/13, 06:43
Looks good to me, but someone else must approvePlease use one line for these. (I'm not sure how the merged issues script reacts here) -
Markus Klein uploaded patch set 3 05/08/13, 06:43
-
Markus Klein commented on patch set 3 05/08/13, 06:43
Verified; Looks good to me, but someone else must approve -
Alexander Opitz commented on patch set 2 05/08/13, 06:43
I would prefer that you didn't submit thisLocalPreviewHelper.php:66Shouldn't this not better replaced with $configuration['width'] = (int) $configuration['width']; $configuration['height'] = (int) $configuration['height']; ? Else we would need escapeshellargs some lines down. -
Alexander Opitz commented on patch set 3 05/08/13, 06:43
Verified; Looks good to me, but someone else must approve -
Alexander Opitz commented on patch set 3 05/08/13, 06:43
(1 inline comment) -
Alexander Opitz commented on patch set 3 1 comment 05/08/13, 06:43
No score -
Christian Kuhn commented on patch set 3 05/08/13, 06:43
(1 inline comment)LocalPreviewHelper.php:66Does it make sense to at least force a positive integer?LocalPreviewHelper.php:66Replyyeah, thats why i ask: width and height *must* be positive, and forceIntegerInRange takes care of that ( -100 -> +1, after that). So, it might make sense, to not only (int) cast it, but also force it to be creater than zero here? -
Christian Kuhn commented on patch set 3 05/08/13, 06:43
(1 inline comment) -
Fabien Udriot uploaded patch set 2 05/08/13, 06:43
LocalPreviewHelper.php:66ReplyLooks as the good solution for me solving all concerns, positive value + casting. +1 for a new patch -
Fabien Udriot commented on patch set 3 05/08/13, 06:43
(1 inline comment) -
Alexander Opitz commented on patch set 4 05/08/13, 06:43
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 4 05/08/13, 06:43
Verified; Looks good to me, but someone else must approve -
Fabien Udriot uploaded patch set 4 05/08/13, 06:43
-
Fabien Udriot commented on patch set 4 05/08/13, 06:43
In last patch, went with approach Utility\MathUtility::forceIntegerInRange($configuration['height'], 1) for solving positive value + casting of width and height. -
Mr. Jenkins commented on patch set 1 05/08/13, 06:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8606/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/08/13, 06:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8608/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/08/13, 06:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8689/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/08/13, 06:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8730/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/08/13, 06:43
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 4 V 0 05/08/13, 06:43
by team member; Looks good to me, approved -
Wouter Wolters merged patch set 5 05/08/13, 06:43