Review main Abandoned

20462[BUGFIX] extMgm importList. Field review_state should be quoted

Laurent Cherpit CR 0 V 0 Easy +1 −1 updated 04/12/14, 22:08

Commit message

During import process, some fields are explicitly unquoted.
One of them is "review_state" and that field is rarely set.
But it contains a string and it should be quoted

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 10

  1. Laurent Cherpit commented on patch set 1 05/27/13, 17:19

    (1 inline comment)
  2. Laurent Cherpit uploaded patch set 2 05/27/13, 17:19

  3. Dominique Feyer commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  4. Dominique Feyer commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  6. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  7. Wouter Wolters commented on patch set 1 05/27/13, 17:19

    (1 inline comment)
    6.1 is released, so now also 6.2 needs to be added here:)
  8. Wouter Wolters commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  9. Jigal van Hemert commented on patch set 2 V -1 CR -2 06/23/13, 08:19

    review_state is an integer field and should not be quoted. If the value from the import is not an integer value the import file should be fixed. Furthermore, the index that is removed in this patch is the index of the 'category' field (also an integer value) and not of the 'review_state' field.
  10. Laurent Cherpit abandoned the change 04/12/14, 22:08

    Reply

    Yep! ^^