Review TYPO3_6-0 Merged

20509[BUGFIX] Label in list view is not escaped

Stefan Neufeind CR +2 V +2 Easy +17 −7 updated 06/03/13, 20:49

Commit message

The label of a field in the list view is not escaped,
as the itemLabel function is broken, through the
third parameter which cannot be HSCed afterwards
if it contains HTML.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +2
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +2

Files 2

Review log 4

  1. Wouter Wolters commented on patch set 2 V 0 05/11/13, 15:48

    by team member; Looks good to me, approved Same as master only the deprecation message is removed.
  2. Nicole Hummel commented on patch set 2 V 0 05/11/13, 15:48

    by team member; Looks good to me, approved Removed deprecation message as it is not important for version 6.0 Waiting for Jenkins review
  3. Nicole Hummel uploaded patch set 2 05/11/13, 15:48

  4. Wouter Wolters merged patch set 3 05/11/13, 15:48