Review main Merged

20542[BUGFIX] Enable table property for all user settings types

Philipp Gampe CR +2 V +2 Easy +13 −8 updated 07/05/13, 21:26

Commit message

The property 'table' for user settings can also be used for other
types than password and text.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 17

  1. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  2. Jigal van Hemert updated the commit message in patch set 1 06/07/13, 19:26

  3. Mr. Jenkins commented on patch set 2 06/07/13, 19:27

  4. Jigal van Hemert commented on patch set 2 V +1 CR +1 06/07/13, 19:34

    SetupModuleController.php:494

    CGL nitpick : indent "case". Can be done before merging.
  5. Philipp Gampe commented on patch set 2 06/08/13, 15:27

    SetupModuleController.php:494 Reply

    not part of this patchset IMHO, I prefer atomic changes
  6. Jigal van Hemert commented on patch set 2 06/08/13, 15:48

    SetupModuleController.php:494 Reply

    policy is that if you touch a function you take care of CGL problems at the same time
  7. Wouter Wolters commented on patch set 2 06/08/13, 19:12

    SetupModuleController.php:494 Reply

    IMO that is not a correct policy. That will bump up the patchset to review. I'd suggest to create a ticket and push a seperate patch to improve the CGL. That way it is easier to review both patches.
  8. Philipp Gampe commented on patch set 2 06/15/13, 12:46

    push, needs review and test by anyone
  9. Philipp Gampe commented on patch set 2 06/16/13, 16:05

    You can test with: https://github.com/pgampe/authenticator Check whether user settings [enable] checkbox sets the same field in the backend users table.
  10. Stefan Neufeind commented on patch set 2 CR +1 06/30/13, 12:40

    SetupModuleController.php:494 Reply

    I agree with Wouter, so I opened a separate ticket for that: http://forge.typo3.org/issues/49527 It looks like several files are affected and imho it's easier to do them all in one easy patch.
  11. Patrick Schriner voted on patch set 2 V +1 CR +1 07/05/13, 20:09

  12. Philipp Gampe voted on patch set 2 V +2 CR +2 07/05/13, 20:40

  13. Christian Kuhn uploaded patch set 3 07/05/13, 21:21

  14. Christian Kuhn commented on patch set 3 V +2 CR +2 07/05/13, 21:21

    rebased, no code change, votes complete, merged.
  15. Christian Kuhn merged patch set 4 07/05/13, 21:21

  16. Mr. Jenkins commented on patch set 3 07/05/13, 21:22

  17. Philipp Gampe commented on patch set 4 07/05/13, 21:26

    Cherry Picked This patchset was cherry picked to change: Icf69d480013ff1be6c0b5d43212c179468885344