Review main Merged

20554[BUGFIX] TCA load regression in eid context

Christian Kuhn CR +2 V +2 Easy +9 −1 updated 06/03/13, 20:49

Commit message

TCA refactoring in 6.1 misses an edge case:
Frontend index_ts loads TCA *after* eid is handled, so there is
no TCA loaded in eid context. Eid scripts that still need
TCA *should* call EidUtility::initTCA(), but some call instead
TSFE->includeTCA(). But includeTCA() is empty now and deprecated.

The patch adds a call to includeTCA() to load TCA, if
GLOBALS['TCA'] array is empty. This makes sure populating TCA
is done only once.

ext:caretaker_instance is affected by this, eg. test "Check
backend user accounts" needs TCA and fails without the patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1