20602[BUGFIX] ADOdb: Invalid override method signature
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
-
Verified V +2
- Xavier Perseguers +2
Files 11
- typo3/sysext/adodb/adodb/datadict/datadict-access.inc.php+8 −8
- typo3/sysext/adodb/adodb/datadict/datadict-db2.inc.php1+15 −15
- typo3/sysext/adodb/adodb/datadict/datadict-generic.inc.php1+5 −5
- typo3/sysext/adodb/adodb/datadict/datadict-ibase.inc.php+5 −5
- typo3/sysext/adodb/adodb/datadict/datadict-informix.inc.php+5 −5
- typo3/sysext/adodb/adodb/datadict/datadict-mssql.inc.php+3 −3
- typo3/sysext/adodb/adodb/datadict/datadict-mssqlnative.inc.php+3 −3
- typo3/sysext/adodb/adodb/datadict/datadict-oci8.inc.php+9 −9
- typo3/sysext/adodb/adodb/datadict/datadict-sapdb.inc.php+4 −4
- typo3/sysext/adodb/adodb/datadict/datadict-sqlite.inc.php+7 −7
- typo3/sysext/adodb/adodb/datadict/datadict-sybase.inc.php+5 −5
Review log 11
-
Xavier Perseguers commented on patch set 1 05/27/13, 17:19
@Philipp: It's copy-paste from the original (3rd-party) ADOdb code. Code is a mess and does not respect coding standards at all. But all was committed long before Mr. Jenkins coming along and complaining about CGL. I don't know what should be done here, we won't update ADOdb anymore and it is not actively maintained anymore anyway. Should be automatically reformat "all" files we touch in EXT:adodb in order for Mr. Jenkins to be happy? Regarding the test, original reporter had the problem while using PostgreSQL, right after a 1-2-3 install when showing the BE login form. I could reproduce with Oracle instead of PostgreSQL. -
Xavier Perseguers commented on patch set 1 05/27/13, 17:19
You can test by simply reading (PhpStorm helps a lot), as you can easily show that override methods do not use the same parameter list as the base class. I fixed all implementation even if most of them will never be used anyway. -
Philipp Gampe commented on patch set 1 05/27/13, 17:19
(2 inline comments) How would you test this? Include all files?datadict-db2.inc.php:61missing space after comma, same belowdatadict-generic.inc.php:52space ... I guess for all files -
Philipp Gampe commented on patch set 1 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve I could not make it break even by doing: include_once(PATH_site . '/typo3/sysext/adodb/adodb/adodb.inc.php'); $DB = NewADOConnection('oracle'); $dataDic = NewDataDictionary($DB); But the change looks good and I know about the PHP method signature match problem. -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8726/ : FAILURE -
Xavier Perseguers uploaded patch set 2 03/04/14, 15:59
-
Mr. Jenkins commented on patch set 2 CR -1 V -1 03/04/14, 16:14
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/14560/ : FAILURE -
Xavier Perseguers uploaded patch set 3 03/04/14, 16:15
-
Mr. Jenkins commented on patch set 3 03/04/14, 16:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14561/ : SUCCESS -
Xavier Perseguers commented on patch set 3 V +2 CR +2 03/04/14, 17:13
Merged as nobrainer -
Xavier Perseguers merged patch set 4 03/04/14, 17:13