Review main Merged

20602[BUGFIX] ADOdb: Invalid override method signature

Xavier Perseguers CR +2 V +2 Normal +69 −69 updated 03/04/14, 17:13

Commit message

Classes are not overriding the method with a compatible list
of parameters.

Review

  • Code review CR +2
    • Xavier Perseguers +2
  • Verified V +2
    • Xavier Perseguers +2

Files 11

Review log 11

  1. Xavier Perseguers commented on patch set 1 05/27/13, 17:19

    @Philipp: It's copy-paste from the original (3rd-party) ADOdb code. Code is a mess and does not respect coding standards at all. But all was committed long before Mr. Jenkins coming along and complaining about CGL. I don't know what should be done here, we won't update ADOdb anymore and it is not actively maintained anymore anyway. Should be automatically reformat "all" files we touch in EXT:adodb in order for Mr. Jenkins to be happy? Regarding the test, original reporter had the problem while using PostgreSQL, right after a 1-2-3 install when showing the BE login form. I could reproduce with Oracle instead of PostgreSQL.
  2. Xavier Perseguers commented on patch set 1 05/27/13, 17:19

    You can test by simply reading (PhpStorm helps a lot), as you can easily show that override methods do not use the same parameter list as the base class. I fixed all implementation even if most of them will never be used anyway.
  3. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    (2 inline comments) How would you test this? Include all files?

    datadict-db2.inc.php:61

    missing space after comma, same below

    datadict-generic.inc.php:52

    space ... I guess for all files
  4. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve I could not make it break even by doing: include_once(PATH_site . '/typo3/sysext/adodb/adodb/adodb.inc.php'); $DB = NewADOConnection('oracle'); $dataDic = NewDataDictionary($DB); But the change looks good and I know about the PHP method signature match problem.
  5. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8726/ : FAILURE
  6. Xavier Perseguers uploaded patch set 2 03/04/14, 15:59

  7. Mr. Jenkins commented on patch set 2 CR -1 V -1 03/04/14, 16:14

  8. Xavier Perseguers uploaded patch set 3 03/04/14, 16:15

  9. Mr. Jenkins commented on patch set 3 03/04/14, 16:29

  10. Xavier Perseguers commented on patch set 3 V +2 CR +2 03/04/14, 17:13

    Merged as nobrainer
  11. Xavier Perseguers merged patch set 4 03/04/14, 17:13