Review main Merged

20700[BUGFIX] Add support for float values to arrayExport

Jigal van Hemert CR +2 V +2 Easy +6 −2 updated 06/03/13, 20:49

Commit message

ArrayUtility::arrayExport() must support float values too.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Anja Leichsenring +2
  • Verified V +2
    • Stefan Neufeind +2
    • Anja Leichsenring +2

Files 2

Review log 6

  1. Stefan Neufeind uploaded patch set 2 05/11/13, 19:43

  2. Stefan Neufeind commented on patch set 2 V 0 05/11/13, 19:43

    by team member; Looks good to me, approved Works fine. I just added another testcase so the behaviour for very small (or large) numbers is fixed (will result in exponential notation). That is okay for the case where this function is used (to generate php-code to go in a cache).
  3. Anja Leichsenring commented on patch set 2 V 0 05/11/13, 19:43

    by team member; Looks good to me, approved
  4. Mr. Jenkins commented on patch set 1 05/11/13, 19:43

  5. Mr. Jenkins commented on patch set 2 05/11/13, 19:43

  6. Anja Leichsenring merged patch set 3 05/11/13, 19:43