Review main Merged

20732[BUGFIX] Cannot connect to the current database

Oliver Hader CR +2 V +2 Easy +9 −3 updated 06/03/13, 20:49

Commit message

DatabaseConnection::admin_get_dbs() iterates over all existing
databases during install process and tries to use each of them.
If that fails, an exception is thrown - which is not caught in
the mentioned method.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Alexander Opitz +1
    • Dmitry Dulepov +1
  • Verified V +2
    • Christian Kuhn +2
    • Alexander Opitz +1
    • Dmitry Dulepov +1

Files 1

Review log 8

  1. Dmitry Dulepov uploaded patch set 2 05/16/13, 18:50

  2. Dmitry Dulepov commented on patch set 2 05/16/13, 18:50

    Verified; Looks good to me, but someone else must approve
  3. Markus Klein commented on patch set 1 05/16/13, 18:50

    (2 inline comments)
    6.2 too? (you pushed to master...)

    DatabaseConnection.php:1296

    Lets describe _why_ we have to catch this exception here. e.g. Catch exception to avoid error message for inaccessible databases.
  4. Alexander Opitz commented on patch set 2 05/16/13, 18:50

    Verified; Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 05/16/13, 18:50

  6. Mr. Jenkins commented on patch set 2 05/16/13, 18:50

  7. Christian Kuhn commented on patch set 2 V 0 05/16/13, 18:50

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 3 05/16/13, 18:50