20772[TASK] Hide func menu with only one entry
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Dmitry Dulepov +2
- Philipp Gampe +1
-
Verified V +2
- Wouter Wolters +2
- Dmitry Dulepov +2
- Philipp Gampe +1
Issues 1
Files 1
Review log 14
-
Dmitry Dulepov commented on patch set 1 05/20/13, 13:19
May be, it makes sense to change getFuncMenu() to return empty string in such cases? This may cause issues if there is a label in front of the selector but usually there is none. -
Felix Kopp commented on patch set 1 05/20/13, 13:19
Would like to have this solved for all function menus. Should be integrate an output condition for all menus? -
Felix Kopp commented on patch set 1 05/20/13, 13:19
There is a count within BackendUtility::getFuncMenu. Shall we extend the functionality over there? -
Philipp Gampe commented on patch set 2 05/20/13, 13:19
I would prefer that you didn't submit this the commit message needs an update, will do this once I review this -
Dmitry Dulepov commented on patch set 3 V 0 05/20/13, 13:19
by team member; Looks good to me, approved Tested, works. -
Philipp Gampe uploaded patch set 3 05/20/13, 13:19
-
Philipp Gampe commented on patch set 3 05/20/13, 13:19
Verified; Looks good to me, but someone else must approve I updated the commit message. -
Felix Kopp commented on patch set 2 05/20/13, 13:19
This patch changes the visual behaviour of function menus. -
Felix Kopp uploaded patch set 2 05/20/13, 13:19
-
Mr. Jenkins commented on patch set 1 05/20/13, 13:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8785/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/20/13, 13:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8841/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/20/13, 13:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8843/ : SUCCESS -
Wouter Wolters commented on patch set 3 V 0 05/20/13, 13:19
by team member; Looks good to me, approved -
Wouter Wolters merged patch set 4 05/20/13, 13:19