20796[BUGFIX] Rootline utility must respect pageOverlayFields
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
-
Verified V +2
- Stefan Neufeind +2
Files 1
Review log 27
Show 2 earlier messages
-
Stefan Galinski commented on patch set 2 05/27/13, 17:19
(1 inline comment) -
Ralf Merz commented on patch set 2 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve I´ve tested this on v6.1.0 and can say: It works and there were no side effects. -
Alexander Opitz commented on patch set 2 05/27/13, 17:19
(1 inline comment)Please add a description, what this patch do and how to test. -
Alexander Opitz commented on patch set 2 05/27/13, 17:19
(1 inline comment) I thought Active Developers know how to commit? -
Philipp Gampe commented on patch set 2 05/27/13, 17:19
(2 inline comments) Even by reading the patch, I do not know what it does. Please add some be describing text to the commit message. Rough draft: [BUGFIX] Rootline utility must respect pageOverlayFields TYPO3 localization allows to overlay content with the content from another language if the content does not exists in the current language by setting the following Typo3Script: config.xyz Technically this works by ... The current code always overlays all fields from pages while generating the rootline, even if those are not listed in $GLOBALS['TYPO3_CONF_VARS']['FE']['pageOverlayFields']. Make sure to only overlay fields which are listed in pageOverlayFields while traversing the rootline. Resolves: #48224 Releases: 6.2, 6.1, 6.0 Change-Id: I6f5a10150c916df24542ee83e33663a27bdb593f That way reviewing is easier, also you later know why a certain line is in the code (a feature I use really often during debugging). It looks like a lot of work, but it really helps later. It makes you think twice about your patch, making sure that you really cover all problems. Remember to always answer: What? (When?) Why? How? -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8790/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8791/ : SUCCESS -
Stefan Galinski updated the commit message in patch set 2 06/10/13, 13:35
Reply
IMHO test instructions doesn't belong to a git commit message. Please see the forge entry for details... :-)Reply
Where do you see any note about test instructions on this page? A more detailed description can(!) be added, but IMHO it's simply not necessary in this case or better I don't know that I should describe here. :-) -
Stefan Galinski updated the commit message in patch set 3 06/10/13, 13:36
-
Stefan Galinski updated the commit message in patch set 4 06/10/13, 13:36
-
Mr. Jenkins commented on patch set 3 CR -1 V -1 06/10/13, 13:36
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/9006/ : FAILURE -
Mr. Jenkins commented on patch set 4 CR -1 V -1 06/10/13, 13:37
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/9007/ : FAILURE -
Stefan Galinski updated the commit message in patch set 5 06/10/13, 13:38
-
Mr. Jenkins commented on patch set 5 06/10/13, 13:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9008/ : SUCCESS -
Mr. Jenkins commented on patch set 6 06/10/13, 13:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9009/ : SUCCESS -
Stefan Neufeind commented on patch set 6 CR +1 06/17/13, 21:03
reading the patch and talking to StefanG this seems to make sense to me. When the column is not overlayed in the page-record the original uid will be used for querying. StefanG mentioned that this is for example testable with the media-field. @Steffen: Could you please have a closed look maybe? You worked some more on the rootline-things. -
Steffen Ritter commented on patch set 6 CR -1 06/18/13, 04:43
Hi, I want to have a deep look at this again as the whole rootline stuff back then cost days and is highly complex... Will get to it end of the week. Until then I put a "security" -1 -
Steffen Ritter commented on patch set 6 CR +1 06/22/13, 07:27
Ok had a look at it and thought it through - makes sense. Anyhow I'm not able to test it - media is in 'pageOverlayFields' so the patch does not change anything in the use case you point out. -
Stefan Galinski commented on patch set 6 06/22/13, 12:07
Hi Steffen, Thanks for testing! The use case for the media field must be seen from the other side. If the media field is not in the pageOverlayFields always the media information from the default language should be shown. Unfortunatly the current behaviour overwrites this information in any case and you will see nothing instead an image in the frontend of non-default languages. :-) Some test instructions: http://forge.typo3.org/issues/48224 -
Torben Hansen commented on patch set 6 V +1 CR +1 06/25/13, 10:18
Patch tested and verified on TYPO3 6.1 I think this patch should be merged asap, since the translation behaviour of TYPO3 for not transladted media fields is broken at the moment. -
Jigal van Hemert commented on patch set 6 V +1 06/29/13, 11:33
Can be merged if the in_array() is changed.RootlineUtility.php:249Please use strict comparison in in_array() (third parameter set to TRUE) to prevent strange side effects. -
Stefan Neufeind uploaded patch set 7 06/29/13, 12:06
-
Stefan Neufeind commented on patch set 7 V +2 CR +2 06/29/13, 12:07
Just changed in_array as per Jigal's suggestion. Votes still apply. -
Stefan Neufeind merged patch set 8 06/29/13, 12:07
-
Mr. Jenkins commented on patch set 7 06/29/13, 12:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9257/ : SUCCESS