Review main Merged

20856[TASK] Update phpdoc of pi_getPageLink/pi_linkToPage

Stefan Neufeind CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

Calls methods in contentObjectRenderer and thus
should match that phpdoc over there (especially
giving a hint about what to urlencode and what not).

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 05/19/13, 16:23

    What is to be escaped and what not just came up in https://review.typo3.org/17176 which adds rawencode() for the parameter-keys. Imho it's a good idea to clarify that in phpdoc, especially since it's already clear in the function that is being called.
  2. Philipp Gampe commented on patch set 1 05/19/13, 16:23

    Verified; Looks good to me, but someone else must approve

    AbstractPlugin.php:284

    add an @see TYPO3::CMS::Frontend::ContentObject::ContentObjectRenderer::getTypoLink() to generate a link to the function for the API reference

    AbstractPlugin.php:301

    same here
  3. Mr. Jenkins commented on patch set 1 05/19/13, 16:23

  4. Wouter Wolters uploaded patch set 2 05/19/13, 16:23

  5. Wouter Wolters uploaded patch set 3 05/19/13, 16:23

  6. Wouter Wolters commented on patch set 3 V 0 05/19/13, 16:23

    by team member; Looks good to me, approved Added the @see as mentioned
  7. Wouter Wolters merged patch set 4 05/19/13, 16:23