Review main Merged

20858[BUGFIX] StorageRepository::findByStorageType() uses wrong typeField

Philipp Gampe CR +2 V +2 Easy +1 −1 updated 07/06/13, 10:44

Commit message

The table "sys_file_storage" has no field "type".
Use the field "driver" instead.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Stefan Neufeind +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  2. Philipp Gampe commented on patch set 1 06/15/13, 12:04

    push
  3. Wouter Wolters uploaded patch set 2 06/15/13, 12:28

  4. Wouter Wolters commented on patch set 2 V +1 CR +1 06/15/13, 12:29

    Obvious.
  5. Frans Saris voted on patch set 2 CR +1 06/15/13, 12:41

  6. Philipp Gampe commented on patch set 2 07/05/13, 21:06

    push, verify by checking typo3/sysext/core/ext_tables.sql
  7. Stefan Neufeind voted on patch set 2 V +2 CR +2 07/06/13, 10:44

  8. Stefan Neufeind merged patch set 3 07/06/13, 10:44