Review main Abandoned

21098[BUGFIX] Fix rendering of empty select fields

Wouter Wolters CR 0 V 0 Easy +1 −1 updated 06/04/13, 19:47

Commit message

Currently an empty option tag will be rendered
if no data is given. This patch removes the
rendering of this option tag and leaves the
select field empty.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 5

  1. Stefan Neufeind commented on patch set 1 05/27/13, 19:19

    Looks good to me, but someone else must approve small fix; seems to make sense by reading imho
  2. Alexander Schnitzler commented on patch set 1 06/01/13, 10:24

    I would prefer that you didn't submit this We have to think about it again. Currently I do not know what is actually sent via HTTP so maybe this breaks some basic functionality.
  3. Dmitry Dulepov commented on patch set 1 06/03/13, 17:48

    I would prefer that you didn't submit this If there is a field with an empty option, it is submitted. The field without options is not submitted. So it may break something in tcemain depending on the setup of the table in $TCA.
  4. Alexander Schnitzler commented on patch set 1 06/03/13, 18:16

    That have been my concerns as well but maybe we could work with a hidden field like the checkbox view helper.
  5. Alexander Schnitzler abandoned the change 06/04/13, 19:47