Review main Abandoned

21100[BUGFIX] Enable Escaping Interceptor in XML request format

Wouter Wolters CR 0 V 0 Easy +1 −1 updated 10/11/13, 08:48

Commit message

The Escaping Interceptor should be enabled if the request format is XML.
As of now this is only done in HTML.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Anja Leichsenring commented on patch set 1 05/31/13, 13:56

    Do not submit there is still some discussion ongoing on forge, lets wait for the outcome. Btw, there is IMHO just no sense in escaping XML with htmlspecialchars().
  2. Anja Leichsenring commented on patch set 1 10/06/13, 08:17

    I am inclined to abandon this patch due to inactivity. The proposed change here is senseless, it needs a more expensive approach to properly escape xml output. (see forge) If someone objects against closing this change, please do something noticeable about it.
  3. Tim Kandel commented on patch set 1 10/11/13, 08:42

    I'm all in favor of abandoning. Will revisit this topic when I get a chance to implement the correct approach in Flow
  4. Wouter Wolters abandoned the change 10/11/13, 08:48