Review main Merged

21123[FEATURE] Automatically determine page type for URIs with format

Wouter Wolters CR +2 V +2 Normal +78 −3 updated 06/03/13, 20:49

Commit message

When rendering a special format a custom page type is required.
This adds a mapping configuration to define which page type
should be used for which format.

Example:
plugin.tx_myext {
    view.formatToPageTypeMapping {
        txt = 99
        pdf = 123
    }
}

The formats defined will apply to all Plugins in your extension.

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2

Issues 1

Files 3

Review log 6

  1. Mr. Jenkins commented on patch set 1 05/27/13, 20:58

  2. Stefan Neufeind commented on patch set 1 05/28/13, 11:01

    Looks good to me, but someone else must approve It looks like this was "almost ready" over at https://review.typo3.org/#/c/2798/ Had 3x verified, 4x code-review.
  3. Alexander Schnitzler commented on patch set 1 06/01/13, 12:03

    So, if nothing changed between the patches I do not see any problem in merging it without all the reviews again. So whoever likes to merge, adjust the release number and go on. ;)
  4. Anja Leichsenring uploaded patch set 2 06/02/13, 09:20

  5. Anja Leichsenring commented on patch set 2 V 0 06/02/13, 09:21

    by team member; Looks good to me, approved merged with the votes from https://review.typo3.org/2798 (patchset before repo change)
  6. Anja Leichsenring merged patch set 3 06/02/13, 09:21