Review main Abandoned

21195[FEATURE] Overwork typography: bring Helvetica+Arial

Felix Kopp CR 0 V 0 Normal +35 −42 updated 02/02/14, 17:40

Commit message

Verdana was our deere companion for many year -
now it is time to slowly move on.

Brings Helvetica Neue, Helvetica, Arial and sans-serif as
solid replacement for Verdana.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 5

Review log 19

  1. Mr. Jenkins commented on patch set 1 06/02/13, 22:04

  2. Jigal van Hemert commented on patch set 1 06/03/13, 04:23

    I would prefer that you didn't submit this Still in doubt about a -2 :-( As said in #36017 Helvetica / Arial kind of fonts make it very hard to read the difference between an uppercase i and a lowercase l. The low x-height compared to Verdana makes it necessary to use a larger font size to make the result somewhat readable. All supported browsers can use some form of @font-face fonts, so we're not limited to system fonts anymore. The choice of a font for a backend should not be about making a pretty picture, but about making it easy to read information and not having to guess which character is displayed.
  3. Felix Kopp commented on patch set 1 06/03/13, 07:47

    Yes, using font-face is technically possible. We chose Helvetica/Arial to use a system font. The font size had been increased. Which of your questions was not answered? You think Helvetica/Arial is not suitable with increased font-size?
  4. Jigal van Hemert commented on patch set 1 06/03/13, 10:22

    @Felix: not a question, but a fact. Look at how certain glyphs look in various fonts. - uppercase i, lowercase l, number 1 - ([{}]) - lowercase o, uppercase o, number 0 Verdana, as ugly as it may be, has very distinctive shapes for each letter/number glyph. It's easy to see which letter/number is displayed. Helvetica/Arial/Grotesk/etc. have similar shapes for the uppercase i and lowercase l. Other fonts have old style numbers where the number 0 and lowercase o are similar. Although Verdana is a little wider than most typefaces the increased x-height allows you to use a smaller size and still have a readable text. Not all fonts are hinted and/or optimized for use on low resolution devices. Verdana is an example of a font that is hand hinted and optimized for screen use. In case you need narrower font there is Tahoma and for mobile devices Nina. I'm not a fan of Verdana but it has many positive properties in this use case. There are of course other fonts that also meet the requirements for use in a backend of TYPO3 (it also needs to support a large part of the unicode character set).
  5. Dmitry Dulepov commented on patch set 1 06/03/13, 17:43

    Fails; Do not submit Looks ugly :( Especially page tree.
  6. Felix Kopp commented on patch set 1 06/03/13, 17:59

    Dmitry, please elaborate. "Looks ugly" is not a valid argument for your veto.
  7. Ernesto Baschny commented on patch set 1 06/03/13, 21:12

    Opinions on that matter are usually very subjective. This is why we have a "Usability" team which decides this stuff instead of us developers. It looks pretty clear to me that Jens approved the change: http://forge.typo3.org/issues/36017#note-14 We'll have a UX meeting at dkd in two weeks, where we can further discuss the backend "CD" further and also include the arguments about the font type.
  8. Jigal van Hemert commented on patch set 1 CR -2 06/04/13, 07:34

    @Ernesto : and if you give objective arguments then those arguments should be completely ignored? Besides, nobody of the UX team has given objective arguments in favour of a Grotesque font. It basically was like "Verdana is ugly, Helvetica is much better". Just changed to -2 until there is either a better alternative to Verdana or there are valid, objective arguments in favour of a Grotesque-type font.
  9. Dmitry Dulepov commented on patch set 1 06/04/13, 12:08

    Well, the page tree is too small. It is very hard to read in case if there many levels and many of them open. A big strain for eyes. Due to the different letter spacing, many things in BE look too narrow. TYPO3 is not a system, which is proud of a few options in forms. We have a lot of them. And having them in other font makes everything look like in the beginning of nineties: too small, too crowded. I think Jens simply did not see how it looks like. It is difficult to work with these new fonts. Very difficult. So my -2 remains.
  10. Markus Klein commented on patch set 1 CR -1 06/04/13, 15:56

    Basically I agree to change the fonts, but in the current state this looks a bit weird. Fonts for module list on the left and the page tree should be a tick bigger. In the editforms the relation of fontsize between the field content and the labels seems a bit strange.
  11. Felix Kopp commented on patch set 1 06/04/13, 16:02

    This patchset will be discussed at UX meeting in June. There might be follow-up.
  12. Felix Kopp uploaded patch set 2 07/08/13, 22:10

  13. Mr. Jenkins commented on patch set 2 07/08/13, 22:11

  14. Felix Kopp uploaded patch set 3 07/08/13, 22:32

  15. Mr. Jenkins commented on patch set 3 07/08/13, 22:33

  16. Markus Klein commented on patch set 3 07/09/13, 10:19

    I hope you're aware that neither Helvetica nor Share are preinstalled fonts on Windows. Even if you install MS Office or Adobe Suites, which ship quite some fonts, you won't have them available.
  17. Alexander Schnitzler commented on patch set 3 07/09/13, 16:15

    For sure he knows that. But what's the matter? There's a fallback to Arial which is the current state and will be if you are using windows. So, at least for mac users the backend is much nicer than before.
  18. Jigal van Hemert commented on patch set 3 V -1 07/09/13, 17:12

    Pagetree is still too small to be readable. Loads of places still have Verdana (form elements, ExtJs stuff, info blocks in workspaces, tooltips, ...). Headers of List module tables too small to be readable. More important: see #36017 for objective problems with Helvetica/Arial.
  19. Felix Kopp abandoned the change 02/02/14, 17:40

    No need