21436[FEATURE] ViewHelper to display file sizes
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Zbigniew Jacko +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Zbigniew Jacko +1
- Philipp Gampe +1
Issues 2
Files 2
Review log 13
-
Stefan Neufeind commented on patch set 1 V +1 CR +1 06/14/13, 23:36
works for me (both tests as well as actual usage in a template) -
Philipp Gampe commented on patch set 1 CR -1 06/14/13, 23:37
peta is missing in the middle of the sequence. If this is a backport, it might be missing in Flow too.BytesViewHelper.php:42kilo-, mega-, giga-, tera-, ***peta-***, exa-, zetta-, yotta- -
Stefan Neufeind commented on patch set 1 V 0 CR -2 06/14/13, 23:45
Thanks Philipp. Great catch. I didn't expect *THAT* from a properly reviewed feature upstream. Filed a bug "upstream": http://forge.typo3.org/issues/49143 -
Stefan Neufeind commented on patch set 1 06/15/13, 00:42
Please let's wait until we can get this sorted out "upstream", in Flow Fluid). https://review.typo3.org/21446 -
Wouter Wolters uploaded patch set 2 06/21/13, 15:59
-
Mr. Jenkins commented on patch set 2 06/21/13, 16:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9125/ : SUCCESS -
Stefan Neufeind commented on patch set 2 CR 0 06/21/13, 21:19
BytesViewHelper.php:60is a simple is_numeric okay for us? Flow-team decided so for them. Would also allow numbers in hex-notation etc. Usually we'd use canBeInterpretedAsInteger and here now also canBeInterpretedAsFloat (currently under review - which I wrote for that purpose). I don't mind if is_numeric stays. But we should allow it in other parts as well then imho. -
Philipp Gampe commented on patch set 2 06/21/13, 22:23
BytesViewHelper.php:60ReplyIMHO yes -
Philipp Gampe voted on patch set 2 CR +1 06/21/13, 22:26
-
Philipp Gampe voted on patch set 2 V +1 06/21/13, 22:26
-
Zbigniew Jacko voted on patch set 2 V +1 CR +1 06/22/13, 15:32
-
Christian Kuhn voted on patch set 2 V +2 CR +2 06/22/13, 22:18
-
Christian Kuhn merged patch set 3 06/22/13, 22:18