Review main Merged

21681[BUGFIX] ShortcutVH must not ignore options.enableBookmarks

Georg Ringer CR +2 V +2 Easy +16 −10 updated 06/27/13, 09:14

Commit message

Shortcuts/Bookmarks can be disabled for users by using
TsConfig options.enableBookmarks = 0.

This setting must be checked in the ViewHelper too.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Eric Chavaillaz +1
    • Stefan Froemken +1
  • Verified V +2
    • Georg Ringer +2
    • Eric Chavaillaz +1
    • Stefan Froemken +1

Issues 1

Files 1

Review log 5

  1. Mr. Jenkins commented on patch set 1 06/27/13, 08:44

  2. Eric Chavaillaz voted on patch set 1 V +1 CR +1 06/27/13, 08:46

  3. Stefan Froemken voted on patch set 1 V +1 CR +1 06/27/13, 09:09

  4. Georg Ringer voted on patch set 1 V +2 CR +2 06/27/13, 09:14

  5. Georg Ringer merged patch set 2 06/27/13, 09:14