Review TYPO3_6-1 Abandoned

21690[BUGFIX] filename not displayed in selector (file_reference)

Martin Borer CR 0 V 0 Easy +1 −1 updated 09/04/13, 11:12

Commit message

the selector values in BE-fields with type group->file_reference are empty. The filename should be displayed at this place.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Martin Borer uploaded patch set 2 06/27/13, 14:15

  2. Stefan Neufeind commented on patch set 2 06/28/13, 23:00

    comments inline. On forge the author of that forge-issue mentioned the patch seems to work for him.
    maybe some short hint here that this refers to BE forms?
    This part should only be used for more detailed explanations about the patch itself. Review-comments or explanations you can add as a comment in gerrit.
    Add all Releases (comma-separated) this fix applies to. At least also 6.2 (which is current master) I guess, but maybe also versions below? Skip 4.6 as this is no longer maintained. Then first submit it to the highest Release this patch is needed for - so you'd usually submit it to "master". The patch for 6.1 here would later be part of backports - that's what the Releases-line is for.

    FormEngine.php:3649

    About the check (first part of ternary operator): Should work this may, but I personally tend to use isset() in that case or maybe even check the count() of that array to have it clean. That's a bit of personal taste though.
  3. Martin Borer commented on patch set 2 06/29/13, 15:14

    looks like there are other issues with internal_type 'file_reference'... for example, the sys_reference entries for such fields are not correct. I will write a ticket about this issue. It's possible that this patch will be unneeded after the reference issue is solved. @Stafan thanks for your hints about my Commit Message. Will take care of it next time. ;)
  4. Martin Borer commented on patch set 2 06/29/13, 15:20

    FormEngine.php:3649 Reply

    count and isset will return true... $itemParts[1] exists in this case but is an empty string.
  5. Martin Borer updated the commit message in patch set 2 07/02/13, 09:56

  6. Martin Borer abandoned the change 09/04/13, 11:12

    Not master.. continue with: https://review.typo3.org/#/c/23058/ and backport later to 6.1