Review main Merged

21705[BUGFIX] ActionController must use namespaced object view pattern

Alexander Schnitzler CR +2 V +2 Normal +62 −2 updated 06/28/13, 18:39

Commit message

The ActionController still uses the old pattern like
Tx_@extension_View_@controller_@action@format for resolving
custom view objects. When using a namespaced extension it
must be possible to also use namespaced view objects.
Therefore a new view object pattern has to be introduced:
@vendor\@extension\View\@controller\@action@format

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1

Issues 1

Files 2

Review log 7

  1. Mr. Jenkins commented on patch set 1 06/28/13, 12:45

  2. Anja Leichsenring commented on patch set 1 V +1 06/28/13, 12:54

    ActionController.php:403

    $possibleViewName = str_replace('@vendor', $vendorName, $this->viewObjectNamePattern);
  3. Alexander Schnitzler uploaded patch set 2 06/28/13, 13:13

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 06/28/13, 13:13

  5. Mr. Jenkins commented on patch set 2 06/28/13, 13:13

  6. Wouter Wolters voted on patch set 2 V +2 CR +2 06/28/13, 18:39

  7. Wouter Wolters merged patch set 3 06/28/13, 18:39