Review main Merged

21785[TASK] Split up typolink() functionality in multiple methods - Part 1

Benni Mack CR +2 V +2 Hard +240 −128 updated 05/29/15, 15:12

Commit message

The cObj->typolink() method is one of the biggest code chunks in
the CMS core, and one of the most central ones for the frontend.
However, it is hard to test, debug and understand. That's why certain
separate parts can be split up in multiple methods.

The first step provides the following changes:

* More readable variables within the method
* Split up the detection, whether it is a mail link,
  external url etc in a separate method
* Split up the string explode functionality of "23 - myclass"
  into a separate method

There are unit tests missing. Also, resolving each link type
could be put in a separate method as well in a further step.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1