21815[TASK] Convert log levels from string to integer
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Issues 1
Files 3
Review log 13
-
Mr. Jenkins commented on patch set 1 07/02/13, 16:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9318/ : SUCCESS -
Markus Klein commented on patch set 1 07/02/13, 21:40
Logger.php:181Why do we have to do the same check here again? Doesn't the check in normalizeLevel() already suffice? -
Steffen Müller commented on patch set 1 07/02/13, 22:24
Logger.php:181Replyyou are right. -
Steffen Müller uploaded patch set 2 07/02/13, 22:24
-
Mr. Jenkins commented on patch set 2 07/02/13, 22:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9324/ : SUCCESS -
Markus Klein commented on patch set 2 CR +1 07/03/13, 07:27
Logger.php:177Missing @throws \RangeException if the given log level is invalidLogger.php:181I guess we can remove the namespace everywhere. -
Steffen Müller commented on patch set 2 07/04/13, 13:53
Logger.php:177Replyno. the exception is thown in Class LogLevel: http://forge.typo3.org/projects/typo3v4-core/repository/revisions/master/entry/typo3/sysext/core/Classes/Log/LogLevel.php#L142Logger.php:181ReplyI will do that in another issue. Let's keep this one as granular as possible. -
Christian Kuhn voted on patch set 2 V +1 CR +1 07/04/13, 14:00
-
Christian Kuhn uploaded patch set 3 07/04/13, 14:01
-
Wouter Wolters voted on patch set 3 V +1 CR +1 07/04/13, 14:02
-
Mr. Jenkins commented on patch set 3 07/04/13, 14:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9352/ : SUCCESS -
Christian Kuhn voted on patch set 3 V +2 CR +2 07/04/13, 14:03
-
Christian Kuhn merged patch set 4 07/04/13, 14:03