Review main Merged

21815[TASK] Convert log levels from string to integer

Steffen Müller CR +2 V +2 Easy +30 −1 updated 07/04/13, 14:03

Commit message

In PSR-3, severity levels for log() can be given as a string.
If a string is given, it gets converted to the corresponding
constant of LogLevel.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 3

Review log 13

  1. Mr. Jenkins commented on patch set 1 07/02/13, 16:51

  2. Markus Klein commented on patch set 1 07/02/13, 21:40

    Logger.php:181

    Why do we have to do the same check here again? Doesn't the check in normalizeLevel() already suffice?
  3. Steffen Müller commented on patch set 1 07/02/13, 22:24

    Logger.php:181 Reply

    you are right.
  4. Steffen Müller uploaded patch set 2 07/02/13, 22:24

  5. Mr. Jenkins commented on patch set 2 07/02/13, 22:26

  6. Markus Klein commented on patch set 2 CR +1 07/03/13, 07:27

    Logger.php:177

    Missing @throws \RangeException if the given log level is invalid

    Logger.php:181

    I guess we can remove the namespace everywhere.
  7. Steffen Müller commented on patch set 2 07/04/13, 13:53

    Logger.php:181 Reply

    I will do that in another issue. Let's keep this one as granular as possible.
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 07/04/13, 14:00

  9. Christian Kuhn uploaded patch set 3 07/04/13, 14:01

  10. Wouter Wolters voted on patch set 3 V +1 CR +1 07/04/13, 14:02

  11. Mr. Jenkins commented on patch set 3 07/04/13, 14:02

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 07/04/13, 14:03

  13. Christian Kuhn merged patch set 4 07/04/13, 14:03