Review TYPO3_4-5 Abandoned

21853[BUGFIX] Respect HTTP_X_FORWARDED_PROTO for SSL

Christian Bönning CR 0 V 0 Easy +2 −1 updated 07/14/13, 10:21

Commit message

The HTTP Header "X-Forwarded-Proto" is a defactostandard which
may be sent by Frontend-Proxies/Load-Balancers to let its
Backend-Server know which protocol was used to start the
original request.

SSL Requests can be terminated at a transparent Frontend-Proxy
(e.g. nginx) and passed to the Backend-Server via plain HTTP
in this case.

This is the second attemp to fix the issue. The original
Change was voted down for security considerations. Now there
is a flag which needs to be set to true manually within
Install Tool ("AcceptXForwardedProtoSSL").

This should only be set in case the HTTP Header is explicitly
set by the Frontend-Proxy and cannot be passed in by a client.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 2