21931[TASK] sys_file/sys_file_reference override strategy
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
-
Verified V +2
- Steffen Ritter +2
Issues 1
Files 4
Review log 29
Show 4 earlier messages
-
Mr. Jenkins commented on patch set 1 07/05/13, 13:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9392/ : SUCCESS -
Andreas Wolf uploaded patch set 2 07/05/13, 14:15
-
Mr. Jenkins commented on patch set 2 07/05/13, 14:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9395/ : SUCCESS -
Felix Kopp updated the commit message in patch set 2 07/05/13, 14:38
-
Mr. Jenkins commented on patch set 3 07/05/13, 14:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9398/ : SUCCESS -
Steffen Ritter uploaded patch set 4 07/05/13, 19:39
-
Steffen Ritter commented on patch set 4 V +1 CR +1 07/05/13, 19:40
small improvement -
Mr. Jenkins commented on patch set 4 07/05/13, 19:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9424/ : SUCCESS -
Andreas Wolf commented on patch set 4 07/05/13, 20:30
FormEngine.php:1143$PA['itemFormElNameActive'] contains a name with square brackets [], which are not allowed for ids. We might get in trouble with these identifiers when using jQuery, and the brackets will have to be escaped (see e.g. http://stackoverflow.com/questions/1239095/find-dom-element-by-id-when-id-contains-square-brackets). Thus, I strongly opt against using these identifiers here! -
Felix Kopp commented on patch set 4 07/13/13, 09:54
CSS is not yet perfect but that is a matter of the core since field are not of the same height in EXT: t3skin.FormEngine.php:1129Is mode added for all fields?FormEngine.php:5923What is the $table parameter needed for?FormEngine.php:6347getValueForFormFieldPlaceholder could be better. Can we rename or do we have to deprecate?locallang_core.xlf:318Concept said: "Override …fieldname…" Not a blocker for me though -
Frans Saris uploaded patch set 5 08/05/13, 12:46
-
Mr. Jenkins commented on patch set 5 08/05/13, 12:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9896/ : SUCCESS -
Frans Saris commented on patch set 5 08/05/13, 12:47
I changed the id handling, added label to translation and added some checks for mode. -
Frans Saris voted on patch set 5 V +1 CR +1 08/05/13, 16:28
-
Frans Saris uploaded patch set 6 08/05/13, 20:14
-
Mr. Jenkins commented on patch set 6 08/05/13, 20:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9903/ : SUCCESS -
Frans Saris uploaded patch set 7 08/07/13, 09:51
-
Mr. Jenkins commented on patch set 7 08/07/13, 09:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9939/ : SUCCESS -
Frans Saris voted on patch set 7 V +1 CR +1 08/19/13, 14:20
-
Steffen Ritter uploaded patch set 8 08/28/13, 12:22
-
Mr. Jenkins commented on patch set 8 08/28/13, 12:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10320/ : SUCCESS -
Steffen Ritter commented on patch set 8 V +2 CR +2 08/28/13, 12:24
just added a wording change requested from Jens Hoffmann. -
Steffen Ritter merged patch set 9 08/28/13, 12:24
-
Helmut Hummel commented on patch set 9 08/29/13, 18:55
Post merge review. Can somebody please take care fixing these issues? thanks!FormEngine.php:45What is that?FormEngine.php:1137htmlspecialchars is wrong in this context and does not properly encode the value GeneralUtility::quoteJsValue() must be used to encode $PA['itemFormElName']FormEngine.php:1147not encoded at all (htmlspecialchars needed)FormEngine.php:1148not encoded at all (htmlspecialchars needed)FormEngine.php:5955Please, no is_numeric when checking for integer -
Philipp Gampe commented on patch set 9 08/31/13, 17:15
Comments of Helmut have not been taken care by now. Please do so or revert the commit. -
Steffen Ritter commented on patch set 9 08/31/13, 18:27
lol Philip, no need for reverting :) No critical issue - and as we just sat together a whole week - allow us some rest... -
Steffen Ritter commented on patch set 9 08/31/13, 18:29
FormEngine.php:5955Replyit does not check if it is an integer ... it checks if it is not a string. as new records will have NEW4352345 within the uid. so no issue here. -
Steffen Ritter commented on patch set 9 09/01/13, 07:44
FormEngine.php:45ReplyDoneFormEngine.php:1137ReplyDoneFormEngine.php:1147ReplyDoneFormEngine.php:1148ReplyDone -
Helmut Hummel commented on patch set 9 09/01/13, 18:57
FormEngine.php:5955ReplyIMHO the check in code does not reflect the expectations. Pushed my proposal to https://review.typo3.org/#/c/23526/2