Review main Merged

22021[BUGFIX] Use database name property in admin_get_tables

Helmut Hummel CR +2 V +2 Easy +2 −2 updated 07/06/13, 15:11

Commit message

The admin_get_tables method in the DatabaseConnection
uses the constant instead of the class property.
This delivers wrong results if using multiple
DatabaseConnection objects.

Use the class property instead.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 9

  1. Helmut Hummel rebased onto patch set 1 07/06/13, 14:55

  2. Mr. Jenkins commented on patch set 1 07/06/13, 14:55

  3. Mr. Jenkins commented on patch set 2 07/06/13, 14:56

  4. Wouter Wolters commented on patch set 2 V +1 CR +1 07/06/13, 15:01

    Looks indeed better.
  5. Markus Klein updated the commit message in patch set 2 07/06/13, 15:07

  6. Mr. Jenkins commented on patch set 3 07/06/13, 15:08

  7. Markus Klein commented on patch set 3 V +2 CR +2 07/06/13, 15:10

    Wouter's votes still valid.
  8. Markus Klein merged patch set 4 07/06/13, 15:10

  9. Markus Klein commented on patch set 4 07/06/13, 15:11

    Cherry Picked This patchset was cherry picked to change: I93e05fdabb53b170782c61ef4ebfa97190cddfb6