22168[BUGFIX] File-Indexer does not flag missing files as deleted
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 18
-
Mr. Jenkins commented on patch set 1 07/09/13, 20:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9549/ : SUCCESS -
Frans Saris voted on patch set 1 V +1 CR +1 07/09/13, 20:42
-
Frans Saris uploaded patch set 2 07/09/13, 20:45
-
Mr. Jenkins commented on patch set 2 07/09/13, 20:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9552/ : SUCCESS -
Frans Saris voted on patch set 2 V +1 CR +1 07/09/13, 20:45
-
Wouter Wolters commented on patch set 2 CR +1 07/09/13, 20:47
Frans, please do not vote your own patches. In Flow/Neos they do this but in CMS this is not allowed;-) or will be taken into account for the voting. -
Frans Saris commented on patch set 2 V 0 CR 0 07/10/13, 06:27
sorry for that. Just a habit, at our company we are supposed to review our own patches. Just revoked my votes. -
Frans Saris commented on patch set 2 07/26/13, 20:34
How to test: 1. Find the file you gonne remove in the sys_file table in database 2. Delete the file (not through TYPO3 but commandline etc) 3. Run file indexer schedular task 4. Reload database view and check the deleted flag Before the patch deleted is false after the patch and a new run of the indexing task the deleted flag is true. -
Steffen Ritter voted on patch set 2 CR -2 08/04/13, 12:04
-
Frans Saris commented on patch set 2 08/04/13, 12:21
Currently the patch doesn't apply because http://forge.typo3.org/issues/48336 is reverted for now. Hope to fix this during fal code sprint. @Steffen, Is that the reason for the -2? -
Steffen Ritter commented on patch set 2 08/04/13, 12:24
No the reason for that is, that there never should have been a deleted flag in the table and it must not be used as it creates plenty of problems because the whole API does not take care of it.... Record should be deleted not flagged deleted. One topic of the next days to find out, how the deleted flag was introduced and clean that all up. -
Frans Saris commented on patch set 2 08/04/13, 12:59
Are you sure we do not want the deleted flag. That way there is no rollback posibility when you delete a file. Use case: There is a folder with multiple files that are used (referenced) in multiple content elements and plugins. By mistake the folder is removed from te server en on the next index run all the fal records get deleted, all the references are broken and meta data is gone. Now you have no idea what files have been removed because all meta data is gone. When you have the deleted flag you exactly know wath is gone, can just re-upload the files and all references are restored. -
Steffen Ritter commented on patch set 2 08/04/13, 13:01
you cannot delete files with references in Backend. -
Frans Saris commented on patch set 2 08/04/13, 13:06
That is true, but not the use case of this issue. The use case is: files get deleted from server and now the fal records table isn't in sync with the file system/storage. Ftp, ssh tools and cloud storage do not respect the fact that referenced files can not be deleted. -
Steffen Ritter commented on patch set 2 08/04/13, 13:09
Don't discuss that here! It will be a topic on the sprint - as long as decided (and implemented) otherwise the the deleted flag is not a concept of FAL prevent -
Steffen Ritter commented on patch set 2 08/18/13, 10:09
this is obsolete now, right? should we abandon? -
Frans Saris commented on patch set 2 08/18/13, 11:41
Yes this is obsolete -
Frans Saris abandoned the change 08/18/13, 11:43
Abandoned in favour of https://review.typo3.org/#/c/22913/