Review main Abandoned

22222[WIP][FEATURE] Introduce "additionalWhereClause" to pagetree

Soren Malling CR 0 V 0 Easy +6 −0 updated 01/27/14, 14:21

Commit message

In user/usergroup specific TSconfig you can set a
"additionalWhereClause" for selecting items to the
pagetree. This is added to the where clause with a "AND"

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 07/11/13, 16:29

  2. Soren Malling commented on patch set 1 CR -1 07/11/13, 16:31

    DataProvider.php:437

    This is currently causing me some pain. The following setting options.pageTree.additionalWhereClause = module = 'fe_users' is generating this where clause 1=1 AND pages.deleted=0 AND (pages.t3ver_state <= 0 OR pages.t3ver_wsid = 0) AND pid= '0' AND module = \'fe_users\' which isn't valid. How to secure this clause best way possible?
  3. Soren Malling uploaded patch set 2 07/11/13, 16:32

  4. Mr. Jenkins commented on patch set 2 07/11/13, 16:32

  5. Soren Malling commented on patch set 2 CR -1 07/11/13, 16:32

    DataProvider.php:437

    This is currently causing me some pain. The following setting options.pageTree.additionalWhereClause = module = 'fe_users' is generating this where clause 1=1 AND pages.deleted=0 AND (pages.t3ver_state <= 0 OR pages.t3ver_wsid = 0) AND pid= '0' AND module = \'fe_users\' which isn't valid and causes no items returned. How to secure this clause best way possible?
  6. Soren Malling uploaded patch set 3 07/11/13, 16:35

  7. Soren Malling commented on patch set 3 CR -1 07/11/13, 16:36

    DataProvider.php:437

    This is currently causing me some pain. The following setting options.pageTree.additionalWhereClause = module = 'fe_users' is generating this where clause 1=1 AND pages.deleted=0 AND (pages.t3ver_state <= 0 OR pages.t3ver_wsid = 0) AND pid= '0' AND module = \'fe_users\' which isn't valid and causes no items returned. How to secure this clause best way possible?
  8. Mr. Jenkins commented on patch set 3 07/11/13, 16:36

  9. Soren Malling rebased onto patch set 3 01/27/14, 14:08

  10. Soren Malling abandoned the change 01/27/14, 14:08

  11. Mr. Jenkins commented on patch set 4 01/27/14, 14:21