Review main Merged

22420[BUGFIX] FAL: Image Processing doesn't respect GFX "thumbnails_png"

Benni Mack CR +2 V +2 Easy +22 −3 updated 08/06/13, 14:32

Commit message

The Task Interface of the File Abstraction Layer defines the
target file extension for graphcal tasks. Previously this was done
with the option "thumbnails_png" from the TYPO3_CONF_VARS.

However, checking for that parameter is not done anymore within
FAL/AbstractGraphicalTask. Thus, all .gif images are shown as .png
files, even though TYPO3 is not configured like that.

This can be seen when using GM, thumbnails_png=0, and creating
a preview image of an animated GIF. The preview will not be shown
for some images then.

The patch introduces the existing option back in to 6.x/FAL.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1