Review main Merged

22508[TASK] Make DiffUtility faster and much more scaleable.

Kasper Ligaard CR +2 V +2 Easy +4 −4 updated 07/23/13, 09:48

Commit message

The method DiffUtility->explodeStringIntoWords() calls array_merge()
inside a loop. The cost of constantly doing a function invocation and
merging arrays needlessly slows the method and the whole diff utility.
Moving the array merging outside the loop, the method becomes faster
and able to handle much larger input.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Jigal van Hemert +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Jigal van Hemert +1

Issues 1

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 07/23/13, 08:09

  2. Markus Klein updated the commit message in patch set 1 07/23/13, 08:25

  3. Markus Klein commented on patch set 2 CR +1 07/23/13, 08:26

    Thanks Kasper! I removed the 4.x version, because 4.6 is not supported anymore and 4.7 and 4.5 only get very important fixes.
  4. Mr. Jenkins commented on patch set 2 07/23/13, 08:26

  5. Kasper Ligaard voted on patch set 2 V +1 CR +1 07/23/13, 08:32

  6. Markus Klein commented on patch set 2 07/23/13, 08:50

    Sorry Kasper, you're not allowed to vote here, since this is your patch and we assure that you've tested it. ;-)
  7. Markus Klein commented on patch set 2 V +1 07/23/13, 09:03

    Diff still works with the patch ;-)
  8. Kasper Ligaard voted on patch set 2 V 0 CR 0 07/23/13, 09:10

  9. Jigal van Hemert voted on patch set 2 V +1 CR +1 07/23/13, 09:26

  10. Wouter Wolters voted on patch set 2 V +2 CR +2 07/23/13, 09:29

  11. Wouter Wolters merged patch set 3 07/23/13, 09:29

  12. Wouter Wolters commented on patch set 3 07/23/13, 09:29

    Cherry Picked This patchset was cherry picked to change: I4c2d21cff9b18392e89e316fec9dc615e715a073
  13. Wouter Wolters commented on patch set 3 07/23/13, 09:29

    Cherry Picked This patchset was cherry picked to change: I4c2d21cff9b18392e89e316fec9dc615e715a073
  14. Kasper Ligaard commented on patch set 3 07/23/13, 09:48

    Travis-CI is sending med "Still Failing" email..? PS: Please also review https://review.typo3.org/#/c/14826/ - it is a bugfix that has been here since September.