Review TYPO3_6-0 Merged

22510[TASK] Make DiffUtility faster and much more scaleable.

Wouter Wolters CR +2 V +2 Easy +5 −5 updated 07/23/13, 09:29

Commit message

The method DiffUtility->explodeStringIntoWords() calls array_merge()
inside a loop. The cost of constantly doing a function invocation and
merging arrays needlessly slows the method and the whole diff utility.
Moving the array merging outside the loop, the method becomes faster
and able to handle much larger input.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 2

  1. Wouter Wolters voted on patch set 1 V +2 CR +2 07/23/13, 09:29

  2. Wouter Wolters merged patch set 2 07/23/13, 09:29